#17385: Cleanup Graph.__init__ and DiGraph.__init__
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.5
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: David Coudert
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/17385 | 3f8a98bc9caa9f64504cf2d85ce4ed39ea7ce12c
Dependencies: #17384 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
True. When I was doing my timings I wasn't thinking of the `None`
simplifications, but FTR:
{{{
sage: x = None
sage: %timeit if x is None: pass
10000000 loops, best of 3: 117 ns per loop
sage: %timeit if x is not None: pass
10000000 loops, best of 3: 102 ns per loop
sage: %timeit if x: pass
10000000 loops, best of 3: 88 ns per loop
sage: %timeit if not x: pass
10000000 loops, best of 3: 101 ns per loop
}}}
I would say the loss of verbosity (according to FF, I'm not making that
word up like I thought) is covered by python ducktyping. Anyways, I don't
really care that much, so if you don't think it should be changed, then
feel free to leave it. Thanks for cleaning this up.
--
Ticket URL: <http://trac.sagemath.org/ticket/17385#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
