#16453: Cythonize quiver paths
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues: Fix issue in bounded
Branch: | integer sequences
u/SimonKing/cythonize_quiver_paths | Commit:
Dependencies: #15820 | 126ee26af9339d6d91b735066d184c410f572bbc
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Why so many includes in `src/sage/quivers/paths.pxd`? You should try to
limit the includes to what you really need. Otherwise you're adding
unneeded dependencies leading to more and slower recompiles. You should
add the following change (plus moving some includes which you need in the
`.pyx` file to the `.pyx` file)
{{{
#!diff
diff --git a/src/sage/quivers/paths.pxd b/src/sage/quivers/paths.pxd
index fd187fc..da7e8fb 100644
--- a/src/sage/quivers/paths.pxd
+++ b/src/sage/quivers/paths.pxd
@@ -1,16 +1,5 @@
-from sage.structure.element cimport MonoidElement, Element
-from sage.data_structures.bounded_integer_sequences cimport *
-from sage.libs.gmp.types cimport *
-from sage.libs.gmp.mpn cimport mpn_cmp
-
-include "sage/ext/python.pxi"
-include "sage/ext/cdefs.pxi"
-include "sage/ext/stdsage.pxi"
-include "sage/libs/ntl/decl.pxi"
-include "sage/ext/interrupt.pxi"
-
-cdef extern from "Python.h":
- bint PySlice_Check(PyObject* ob)
+from sage.structure.element cimport MonoidElement
+from sage.data_structures.bounded_integer_sequences cimport biseq_t
cdef class QuiverPath(MonoidElement):
cdef biseq_t _path
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/16453#comment:47>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
