#16453: Cythonize quiver paths
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues: Fix issue in bounded
Branch: | integer sequences
u/SimonKing/cythonize_quiver_paths | Commit:
Dependencies: #15820 | 126ee26af9339d6d91b735066d184c410f572bbc
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:46 jdemeyer]:
> Is this change needed?
> {{{
> #!diff
> diff --git a/src/sage/data_structures/bounded_integer_sequences.pyx
b/src/sage/data_structures/bounded_integer_sequences.pyx
> index 0ff59d8..29868ff 100644
> --- a/src/sage/data_structures/bounded_integer_sequences.pyx
> +++ b/src/sage/data_structures/bounded_integer_sequences.pyx
> @@ -714,7 +714,7 @@ cdef class BoundedIntegerSequence:
> True
>
> """
> - return NewBISEQ, (bitset_pickle(self.data.data),
self.data.itembitsize, self.data.length)
> + return NewBISEQ, (bitset_pickle(self.data.data) if
self.data.length>0 else (), self.data.itembitsize, self.data.length)
>
> def __len__(self):
> """
> @@ -1357,7 +1357,7 @@ cpdef BoundedIntegerSequence NewBISEQ(tuple
bitset_data, mp_bitcnt_t itembitsize
> # bitset_unpickle assumes that out.data.data is initialised.
> biseq_init(out.data, length, itembitsize)
> sig_on()
> - bitset_unpickle(out.data.data, bitset_data)
> + if bitset_data: bitset_unpickle(out.data.data, bitset_data)
> sig_off()
> return out
>
> }}}
At one point it was needed, and I think I added a test catching it.
Perhaps the underlying problem has now been fixed on the level of bounded
integer sequences or even on the level of bitsets. I need to check...
--
Ticket URL: <http://trac.sagemath.org/ticket/16453#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
