#16453: Cythonize quiver paths
-------------------------------------+-------------------------------------
       Reporter:  SimonKing          |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Simon King         |    Reviewers:
Report Upstream:  N/A                |  Work issues:  Fix issue in bounded
         Branch:                     |  integer sequences
  public/ticket/16453                |       Commit:
   Dependencies:  #15820             |  e03b66156f5b5212bfeffc937887ae5c29a1a6ca
                                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 In these 3 cases, why don't you use the corresponding `biseq` functions?
 {{{
 return mpn_cmp(cself._path.data.bits, other._path.data.bits,
 cself._path.data.limbs)
 }}}

 {{{
 cdef mp_limb_t* p = self._path.data.bits
 for i from self._path.data.limbs>i>=0:
     h0 = h
     h += deref(postinc(p))
     if h<h0: # overflow
         preinc(h)
 }}}

 {{{
 out._path.itembitsize = itembitsize
 out._path.mask_item = limb_lower_bits_up(itembitsize)
 out._path.length = length
 if length>0:
     sig_on()
     bitset_init(out._path.data, 1)
     bitset_unpickle(out._path.data, bitset_data)
     sig_off()
 }}}
 (and the corresponding `bitset_pickle()` of course)

--
Ticket URL: <http://trac.sagemath.org/ticket/16453#comment:76>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to