#17464: Computing the automorphism group of a graph
-------------------------+-------------------------------------------------
Reporter: azi | Owner:
Type: | Status: needs_work
enhancement | Milestone: sage-6.5
Priority: major | Resolution:
Component: graph | Merged in:
theory | Reviewers:
Keywords: | Work issues:
Authors: | Commit:
Report Upstream: N/A | 6679f16ab3db644a285ed8706eafa587eafee4a3
Branch: | Stopgaps:
public/bliss |
Dependencies: |
#17552 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Yop !
> First of all happy new year and stuff!!!!
+1
> and I and vim's :list are just blind... (dont' see it)
What I don't like about "def canonical_label(..." is that the doc appears
BEFORE the function's definition. Could it be that ?
> do you happen to have any new comments about the current code?
Well, definitely there is something wrong in `automorphism_group`, where
you define a keyword `algorithm` but never read it. Then you should
probably add a couple of new doctests using bliss (with an #optional flag)
in the function from `generic_graph`. Whatever you do with this function's
input, you should probably do the same in the similar functions btw:
`canonical_label`, and `is_isomorphic`.
Also, it looks like the test that you run in `is_isomorphic` (number of
edges/vertices) already appear a bit later in the code. No reason to have
them appear twice.
There is still this line which has nothing to do here
{{{
#!diff
+ :meth:`~GenericGraph.geodetic_number` | Returns the geodetic number
of the given graph.
}}}
Oh, and several lines are still longer than 80chr, and we try to wrap them
because ...
Because somebody said that we had to.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17464#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
