#17464: Computing the automorphism group of a graph
-------------------------+-------------------------------------------------
Reporter: azi | Owner:
Type: | Status: needs_work
enhancement | Milestone: sage-6.5
Priority: major | Resolution:
Component: graph | Merged in:
theory | Reviewers:
Keywords: | Work issues:
Authors: | Commit:
Report Upstream: N/A | 1d7afae64c538d1a6a0ffdec31275a65969f2068
Branch: | Stopgaps:
public/bliss |
Dependencies: |
#17552 |
-------------------------+-------------------------------------------------
Comment (by azi):
Replying to [comment:45 ncohen]:
> Hello !
>
> > OFC it has no sense but I was just following the guideline. I've now
changed that so that we check that algorithm = 'bliss' explicitly. In case
you have something else in mind let me know.
>
> Oh sorry, I was thinking of something different:
>
> 1) We want the users who explicitly ask for "bliss" to never run any
other code
> 2) We want users who do not care to run "bliss" if it is available (they
may be calling that code through another functions without knowing)
>
> {{{
> if (algorithm is None and
> is_package_installed("bliss") and
> not edge_labels):
> algorithm = "bliss"
> if algorithm == "bliss":
> try:
> from sage.graphs.bliss import is_isomorphic
> except ImportError:
> raise RuntimeError("You must install the bliss spkg before
running this code")
> <bliss call>
> }}}
And this is to be placed in the say is_isomorphic/automorphism_group part
and so on? If so, isn't this a bit of an overhead to be checked each time?
>
> > The current code passes all the tests and I am open for further
suggestions.
>
> Could you move the code comments that explain the function's behaviour
inside of the function ? As you would do if it were a Python function
(e.g. bliss_graph/bliss_digraph, add_gen) ? It would be cool if you could
also write the documentation of these functions (e.g. INPUT section), even
though you cannot doctest them.
Thanks. I'll do it and post a new branch when I am done.
>
> Could you also document what `empty_hook` is meant for ? It is useless
right now but it would be good to know what it does if we ever want to use
it for something (and that's the kind of stuff which can become *VERY*
useful). Please document its parameters too.
Best,
Jernej
> Thanks,
>
> Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17464#comment:46>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
