#17464: Computing the automorphism group of a graph
-------------------------+-------------------------------------------------
       Reporter:  azi    |        Owner:
           Type:         |       Status:  needs_work
  enhancement            |    Milestone:  sage-6.5
       Priority:  major  |   Resolution:
      Component:  graph  |    Merged in:
  theory                 |    Reviewers:
       Keywords:         |  Work issues:
        Authors:         |       Commit:
Report Upstream:  N/A    |  aed44e8dd39982907467b6e0d699f9def062f1af
         Branch:         |     Stopgaps:
  public/bliss           |
   Dependencies:         |
  #17552                 |
-------------------------+-------------------------------------------------

Comment (by ncohen):

 Hello !

 > That surely didn't help but the error still persists :-S I have no idea
 where the mismatch is.

 Right now when I run the tests on `generic_graph` I get several screens
 filled with "is_package_installed is not defined".

 > Yes I was following your advice from above which was to add a condition
 of the form
 >
 > {{{
 >  if algorithm is None and is_package_installed("bliss") :
 > }}}
 >
 > since we only offer two algorithms for now this works fine, perhaps
 provided that we write the option algorithm="nice" to  indicate the
 currently default implementation? What do you suggest?

 And what happens when you do `G.automorphism_group(algorithm="bliss")` as
 indicated in the function's doc ? `:-P`

 > Is it not enough to have them in bliss.pyx? If not, then I'll add some
 doctests when we agree on the technical aspects of the code

 That would be for advertising purposes. Just one would do, just to
 emphasize that another algorithm is available.

 > 80chr is quite tight :O

 As usual it is some PEP's fault. It probably is PEP8. It is always PEP8's
 fault.

 > Also have you noticed that there appears to be some indentation
 inconsistency in the code? It looks like the functions on the bottom
 (example def graph_isom_equivalent_non_edge_labeled_graph) are not
 indented as the above ones?

 Oh ? No, I never saw that. Well, some hardcore PEP8 guy will probably
 change it some day.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17464#comment:42>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to