#17578: Use Parent/Element for Manin symbols
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: modular forms | Resolution:
Keywords: Manin symbol | Merged in:
Authors: Peter Bruin | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/manin_symbol_parent-17578 | 57a425901538723e212815ab1e84908ff992cf40
Dependencies: #17579 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* cc: was (added)
* commit: e59b940b36c40cca506f7740a480c47369920309 =>
57a425901538723e212815ab1e84908ff992cf40
* branch: u/pbruin/17578-ManinSymbol_Parent_Element =>
u/tscrim/manin_symbol_parent-17578
Comment:
I'm creating the following for the test:
{{{
sage: from sage.modular.modsym.manin_symbols import ManinSymbolList_gamma0
sage: m = ManinSymbolList_gamma0(5,8)
}}}
Previously we have:
{{{
sage: %time L = m.manin_symbol_list()
CPU times: user 560 µs, sys: 84 µs, total: 644 µs
Wall time: 494 µs
sage: %time L = m.manin_symbol_list()
CPU times: user 48 µs, sys: 4 µs, total: 52 µs
Wall time: 68.9 µs
}}}
With my branch:
{{{
sage: %time L = m.manin_symbol_list()
CPU times: user 644 µs, sys: 90 µs, total: 734 µs
Wall time: 747 µs
sage: %time L = m.manin_symbol_list()
CPU times: user 56 µs, sys: 7 µs, total: 63 µs
Wall time: 64.8 µs
}}}
With Peter's branch:
{{{
sage: %time L = m.manin_symbol_list()
CPU times: user 792 µs, sys: 99 µs, total: 891 µs
Wall time: 828 µs
sage: %time L = m.manin_symbol_list()
CPU times: user 49 µs, sys: 6 µs, total: 55 µs
Wall time: 66 µs
}}}
So there is a slowdown with creating the instances of `ManinSymbol` that
comes from the new branch and Peters by creating instances of `Element`.
Hence this is a slowdown we might just have to deal with (assuming one is
actually wanting the `ManinSymbol`, not the indexing tuple which can be
grabbed by `symbol_list`).
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=6494bcddf8e93da8ea5410902931819a681f7e7e
6494bcd]||{{{Trac 17578: move ManinSymbol class (1)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=dcf9d3587e150d1fbe1dc1cd22482716db32767e
dcf9d35]||{{{Trac 17578: move ManinSymbol class (2)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a9da0487574bd6c9e31743929de1a9ae1b476cdb
a9da048]||{{{Trac 17578: use Parent/Element for Manin symbols}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c0701458ba046b936cb250ccb79a7a3baf4181b9
c070145]||{{{Merge branch 'u/pbruin/17578-ManinSymbol_Parent_Element' of
trac.sagemath.org:sage into u/tscrim/manin_symbol_parent-17578}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9cf191b8faf45f97855e5612ed81d7a3988c5cb4
9cf191b]||{{{More changes towards a proper parent class.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=57a425901538723e212815ab1e84908ff992cf40
57a4259]||{{{Merge branch 'u/jdemeyer/ticket/17579' of
trac.sagemath.org:sage into u/tscrim/manin_symbol_parent-17578}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17578#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
