#17578: Use Parent/Element for Manin symbols
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: modular forms | Resolution:
Keywords: Manin symbol | Merged in:
Authors: Peter Bruin | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/manin_symbol_parent-17578 | 9cf191b8faf45f97855e5612ed81d7a3988c5cb4
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:2 tscrim]:
> I've made some more substantial changes making `ManinSymbolList` a
proper parent in `FiniteEnumeratedSets`. In particular, there is a
backwards incompatible change in that `m[i]` returns a `ManinSymbol`
instance (of `m`) rather than a tuple. Also I changed the `_list`
attribute to `_symbol_list` since `FiniteEnumeratedSets` uses `_list`
internally. Lastly I've added a method `symbol_list` to get the explicit
list of symbols (the indexing tuples).
>
> I'm thinking we should post something to sage-devel stating this
(proposed) change. Sound good?
I don't mind too much, but given that this ticket is a dependency of
#10513, which already has positive review, wouldn't it make sense to do
this on a different ticket? (I currently don't have enough time to review
your changes.)
--
Ticket URL: <http://trac.sagemath.org/ticket/17578#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
