#17578: Use Parent/Element for Manin symbols
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  modular forms      |   Resolution:
       Keywords:  Manin symbol       |    Merged in:
        Authors:  Peter Bruin        |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/pbruin/17578-ManinSymbol_Parent_Element|  
e59b940b36c40cca506f7740a480c47369920309
   Dependencies:  #17579             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 I strongly disagree with doing this (IMO) dirty hack of parents just to
 merge it quickly. It creates parents without a category and elements not
 created from the parent, both of which are abuses of `Parent`.

 Also from my understanding, since this branch was published and I based my
 branch on it, it was not good to rebase the branch. Merge commits don't
 hurt anyone.

--
Ticket URL: <http://trac.sagemath.org/ticket/17578#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to