#17573: Wrap Gap Structure Description
-------------------------------------+-------------------------------------
       Reporter:  kcrisman           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.5
      Component:  group theory       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Sergey Bykov       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/captaintrunky/wrap_gap_structure_description|  
3afe347685ec8ccf777c633f9c91bd6f334b1c83
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by captaintrunky):

 Hi, Nathann!
 `StructureDescription` routine seems to be very general, so I agree that
 it should be moved from a special object like `permutation_group`
 somewhere else. I found your solution in these 2 commits reasonable for
 the whole problem.
 Yes, I have already struggled with `sage()/str()`. Maybe we should open a
 ticket for this? I was very surprised that such basic stuff works in
 different (and not obvious) ways under the same cover due to several APIs
 to GAP.
 In conclusion, I think that this ticket may be closed -- the goal is
 achieved.

 Replying to [comment:12 ncohen]:
 > Hello again,
 >
 > I thought for a while about how we could avoid some copy/pate meant to
 handle the GAP output, then ended up using a trick. I wrote a couple of
 commits which do the following:
 >
 > 1) Move {{{structure_description}}} from `permgroup.py` to `generic.py`
 without doing any modification to it
 >
 > 2) Update it a bit (change 'self' into 'G', add a couple of examples)
 then bind this function to the {{{permutation_group}}} and
 {{{finitely_presented_group}}} classes. And also to {{{Matrix_group}}}
 while I was at it.
 >
 > I had to find a workaround for this `.sage()/.str()` problem you must
 have met yourself while you were working on this patch. This code works
 but there is definitely something fishy there.
 >
 > Tell me what you think,
 >
 > Nathann
 >
 > P.S.: Those two commits can be found at: `public/17573`

--
Ticket URL: <http://trac.sagemath.org/ticket/17573#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to