#17573: Wrap Gap Structure Description
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  kcrisman               |       Status:  needs_work
           Type:         |    Milestone:  sage-6.5
  enhancement            |   Resolution:
       Priority:  minor  |    Merged in:
      Component:  group  |    Reviewers:  Nathann Cohen
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  294041b72adf4b10f44f913d7439c33c96524eee
  Sergey Bykov           |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/17573           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by ncohen):

 > At the very least don't impose your idea of the degree of the dihedral
 group on others. Especially if your docs say that you use GAP's
 definititon.

 None of the code that this branch contains does that. As you will find
 from the commits, it merely moves a function from one place to another,
 and the function's body has not been changed.

 > The standard lore is to give a generic implementation as high up as
 possible (e.g. in Group) and then override it with specialized
 implementations where appropriate.

 If you do that, the function will be broken on many groups. It will not
 give wrong or slow results, but will just break. This is why I only added
 it to the classes that I found able to handle it.

 I set this patch back to its original status.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17573#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to