#17573: Wrap Gap Structure Description
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  kcrisman               |       Status:  needs_review
           Type:         |    Milestone:  sage-6.5
  enhancement            |   Resolution:
       Priority:  minor  |    Merged in:
      Component:  group  |    Reviewers:  Nathann Cohen
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  294041b72adf4b10f44f913d7439c33c96524eee
  Sergey Bykov           |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/17573           |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by ncohen):

 * reviewer:   => Nathann Cohen
 * branch:  u/captaintrunky/wrap_gap_structure_description => public/17573
 * commit:  3afe347685ec8ccf777c633f9c91bd6f334b1c83 =>
     294041b72adf4b10f44f913d7439c33c96524eee


Comment:

 Hello!

 > `StructureDescription` routine seems to be very general, so I agree that
 it should be moved from a special object like `permutation_group`
 somewhere else.

 Indeed.

 > I found your solution in these 2 commits reasonable for the whole
 problem.

 Thanks.

 > Yes, I have already struggled with `sage()/str()`. Maybe we should open
 a ticket for this? I was very surprised that such basic stuff works in
 different (and not obvious) ways under the same cover due to several APIs
 to GAP.

 To be honest I would be glad to see it fixed, but I really did not
 understand where the problem came from. For some reason that I do not get,
 calling `str(x)` is not equivalent to `x.__str__()` on some objects `O_o`

 > In conclusion, I think that this ticket may be closed -- the goal is
 achieved.

 Well, then you can switch the ticket's status to `positive_review` and it
 will make it in the next release `:-)`

 Nathann
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=a2d8adeb3100c6e5b28c65c7ef615150557674de
 a2d8ade]||{{{trac #17573: Move structure_description from permgroup.py to
 generic.py}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=294041b72adf4b10f44f913d7439c33c96524eee
 294041b]||{{{trac #17573: update structure_descriptions and bind it to the
 classes}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/17573#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to