#17695: Slightly fasten is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.5
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomials | Reviewers:
Authors: Bruno Grenet | Work issues:
Report Upstream: N/A | Commit:
Branch: | 053a30cc574fb122ec8527c53849419ccf871e68
u/bruno/slightly_fasten_is_cyclotomic__| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Just typographical comment. The `TODO` block must be indented. In other
words
{{{
.. TODO::
As soon as #XYZ is finished we should do blih and blah.
}}}
Have a look to [http://sagemath.org/doc/developer/coding_basics.html
#docstring-markup-with-rest-and-sphinx Docstring section of the developer
manual].
It is `_gp_()` and not `__gp__()` (i.e. one underscore).
I would move the `._gp_().poliscyclo()` below the tests for
characteristic.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/17695#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
