#17912: Cleanup of modform_hecketriangle
-------------------------------------+-------------------------------------
Reporter: jj | Owner:
Type: task | Status: new
Priority: minor | Milestone: sage-6.6
Component: modular forms | Resolution:
Keywords: modular forms | Merged in:
hecke triangle groups | Reviewers:
Authors: Jonas Jermann | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5c8639cdfecb4c8c9217ab85f895f491467841ce
u/jj/modform_refactor1 | Stopgaps:
Dependencies: #17261, #17909 |
-------------------------------------+-------------------------------------
Changes (by jj):
* commit: => 5c8639cdfecb4c8c9217ab85f895f491467841ce
* branch: => u/jj/modform_refactor1
Old description:
> It's worthwhile to cleanup/refactor from time to time.
> This is the aim of this ticket (for modform_hecketriangle).
> Before doing so the two tickets #17261, #17909 should be
> considered/included.
>
> Cleanup / improvements:
> - Think about how original/new modular forms implementation is loaded
> - Move hecke_triangle* to sage.groups.matrix_gps
> - Remove everything from the __init__ and use the mechanism of the all.py
> - groups.matrix.HeckeTriangle(5) should work
> - Create a thematic tutorial from readme.py
> - Use native comparison in number fields once it is available
> - Improve documentation
> - improve introductions in general
> - Clarify the meaning of min_exp
> - Remove unnecessary cached_methods
> - Use _matrix_check
> - "Faster element of order in number fields. Right now it is a bit
> stupid, number field elements carry a
> denominator and compute a gcd after each operation. In an order there
> is no need of denominator and
> operations are much faster."
> - Faster matrices on number fields / orders
> - Refactor analytic type, constructions
>
> Bugfixing:
> - Make detection of modular forms by Fourier expansions more robust
> - construct*form, rationalize_series
> - in particular consider trivial cases and add more validation checks
> - see sagemathcloud demo for calculation of quasiweakforms based on
> coefficients
> - There are bugs with coordinate vectors for quasi forms!
> - ambient coordinate vectors seem to work
> - some_subspace._module.coordinate_vector(ambient_coordinate_vector)
> does not always seem
> to produce the coordinate vector with respect to
> some_subspace.gens()! Note that _module
> is defined as (where gens is essentially the basis):
> ambient_space._module.submodule([ambient_space.coordinate_vector(v)
> for v in basis])
> - There might be bugs with q_basis in some cases (see sagemathcloud demo)
New description:
It's worthwhile to cleanup/refactor from time to time.
This is the aim of this ticket (for modform_hecketriangle).
Before doing so the two tickets #17261, #17909 should be
considered/included.
Cleanup / improvements:
- Think about how original/new modular forms implementation is loaded
- Move hecke_triangle* to sage.groups.matrix_gps
- Remove everything from the __init__ and use the mechanism of the all.py
- groups.matrix.HeckeTriangle(5) should work
- Create a thematic tutorial from readme.py
- Use native comparison in number fields once it is available
- Improve documentation
- improve introductions in general
- Clarify the meaning of min_exp
- Remove unnecessary cached_methods
- Use _matrix_check
- "Faster element of order in number fields. Right now it is a bit stupid,
number field elements carry a
denominator and compute a gcd after each operation. In an order there is
no need of denominator and
operations are much faster."
- Faster matrices on number fields / orders
- Refactor analytic type, constructions
Bugfixing:
- Make detection of modular forms by Fourier expansions more robust
- construct*form, rationalize_series
- in particular consider trivial cases and add more validation checks
- see sagemathcloud demo for calculation of quasiweakforms based on
coefficients
- There are bugs with coordinate vectors for quasi forms! (FIXED)
- There might be bugs with q_basis in some cases (see sagemathcloud demo)
--
Comment:
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=54cc3829ac7f60de6d5c4781e2d04425460c5761
54cc382]||{{{allow coercions from the forms over n=3 to forms over
n=infinity}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c4511d75b10c503500d12999a288c787818e0e42
c4511d7]||{{{Merge branch 'u/jj/triangle_conjugacy' into
u/jj/theta_coercion}}}||
||[http://git.sagemath.org/sage.git/commit/?id=baf6c638b3c85507ef779a2b2a8f376ba0deefc6
baf6c63]||{{{add the multiplication-by-weight operator}}}||
||[http://git.sagemath.org/sage.git/commit/?id=de7a57657b891c029dbc5b6f55c9ae649ee10a64
de7a576]||{{{Merge branch 'u/jj/triangle_conjugacy' into
u/jj/theta_coercion}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4d16ceea6a6a87bc3b6e9dd23899dc3f49c28a79
4d16cee]||{{{Merge branch 'u/jj/theta_coercion' into
u/jj/rankin_cohen_bracket}}}||
||[http://git.sagemath.org/sage.git/commit/?id=bf892415fb7fd43df17cd4c50f422c2212f7f0cc
bf89241]||{{{initial version of Rankin Cohen brackets}}}||
||[http://git.sagemath.org/sage.git/commit/?id=fd1edffd315afd3f706af102f4637314485d4595
fd1edff]||{{{add missing doctests and documentation}}}||
||[http://git.sagemath.org/sage.git/commit/?id=5c8639cdfecb4c8c9217ab85f895f491467841ce
5c8639c]||{{{bugfix: use submodule_with_basis instead of submodule, so
that coordinate vectors really correspond to the specified basis}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17912#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
