#17912: Cleanup of modform_hecketriangle
-------------------------------------+-------------------------------------
Reporter: jj | Owner:
Type: task | Status: new
Priority: minor | Milestone: sage-6.6
Component: modular forms | Resolution:
Keywords: modular forms | Merged in:
hecke triangle groups | Reviewers:
Authors: Jonas Jermann | Work issues:
Report Upstream: N/A | Commit:
Branch: | 360e9feed34bc2176b9747f8b55e28c05c0f36f9
u/jj/modform_refactor1 | Stopgaps:
Dependencies: #17261, #17909 |
-------------------------------------+-------------------------------------
Description changed by jj:
Old description:
> It's worthwhile to cleanup/refactor from time to time.
> This is the aim of this ticket (for modform_hecketriangle).
> Before doing so the two tickets #17261, #17909 should be
> considered/included.
>
> Cleanup / improvements:
> - Think about how original/new modular forms implementation is loaded
> - Move hecke_triangle* to sage.groups.matrix_gps
> - Remove everything from the __init__ and use the mechanism of the all.py
> - groups.matrix.HeckeTriangle(5) should work
> - Create a thematic tutorial from readme.py
> - Use native comparison in number fields once it is available
> - Improve documentation
> - improve introductions in general
> - Clarify the meaning of min_exp
> - Remove unnecessary cached_methods
> - Use _matrix_check
> - "Faster element of order in number fields. Right now it is a bit
> stupid, number field elements carry a
> denominator and compute a gcd after each operation. In an order there
> is no need of denominator and
> operations are much faster."
> - Faster matrices on number fields / orders
> - Refactor analytic type, constructions
>
> Bugfixing:
> - Make detection of modular forms by Fourier expansions more robust
> - construct*form, rationalize_series
> - in particular consider trivial cases and add more validation checks
> - see sagemathcloud demo for calculation of quasiweakforms based on
> coefficients
> - There are bugs with coordinate vectors for quasi forms! (FIXED)
> - There might be bugs with q_basis in some cases (see sagemathcloud demo)
New description:
It's worthwhile to cleanup/refactor from time to time.
This is the aim of this ticket (for modform_hecketriangle).
Before doing so the two tickets #17261, #17909 should be
considered/included.
Cleanup / improvements:
- Think about how original/new modular forms implementation is loaded
- Move hecke_triangle* to sage.groups.matrix_gps
- Remove everything from the __init__ and use the mechanism of the all.py
- groups.matrix.HeckeTriangle(5) should work
- Create a thematic tutorial from readme.py
- Use native comparison in number fields once it is available
- Improve documentation
- improve introductions in general
- Clarify the meaning of min_exp
- Remove unnecessary cached_methods
- Use _matrix_check
- "Faster element of order in number fields. Right now it is a bit stupid,
number field elements carry a
denominator and compute a gcd after each operation. In an order there is
no need of denominator and
operations are much faster."
- Faster matrices on number fields / orders
- Refactor analytic type, constructions
Bugfixing:
- Make detection of modular forms by Fourier expansions more robust
(FIXED?)
- There are bugs with coordinate vectors for quasi forms! (FIXED)
- There might be bugs with q_basis in some cases (see sagemathcloud demo)
--
--
Ticket URL: <http://trac.sagemath.org/ticket/17912#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
