#17905: Dominating set in directed Graphs not correct
-------------------------------------+-------------------------------------
Reporter: Mantis | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: graph theory | Resolution:
Keywords: dominating_set, | Merged in:
Graphs, Directed Graphs | Reviewers:
Authors: Sergios Lenis | Work issues:
Report Upstream: N/A | Commit:
Branch: | 7d0c749b1eb9d1b208f53c9b3a99ecaec16ee1bb
u/Mantis/dominating_set_in_directed_graphs_not_correct| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hellooooooo!
Your branch looks good, and almost ready to go. I just had a look at it,
and made two modifications:
1) One line of documentation was very long (we try to keep lines to max 80
characters unless it makes it harder to read: that's a Python standard) so
I wrapped it around.
2) Your if/else can be written in one line
{{{
#!diff
- if g.is_directed():
- neighbors_iter=g.neighbor_in_iterator
- else:
- neighbors_iter=g.neighbor_iterator
+ neighbors_iter=g.neighbor_in_iterator if g.is_directed() else
g.neighbor_iterator
}}}
I added a small commit on top of your branch. That new branch is named
public/17905.
As I reviewed your changes and added a commit, you have to review mine
before this ticket can be merged. Of course, tell me if there is anything
that you do not like, and we will discuss it.
Cheers,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17905#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
