#17730: Use Pari for is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomial | Reviewers:
Authors: Vincent Delecroix | Work issues:
Report Upstream: N/A | Commit:
Branch: | c75798cbe2b9e101f03c67d4ca9bc1c3624df31a
public/ticket/17730 | Stopgaps:
Dependencies: #17631 |
-------------------------------------+-------------------------------------
Changes (by chapoton):
* commit: 146d1d0c8f4c50e013a75a143d8493d5c1bce1f0 =>
c75798cbe2b9e101f03c67d4ca9bc1c3624df31a
* branch: u/vdelecroix/17730 => public/ticket/17730
Comment:
Looks good to me.
I have made a review commit:
- moving things around inside `is_cyclotomic`
- changing the following behavior: if we ask for a certificate, then pari
is used
If you agree with my changes, you can set a positive review
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=78310eaef070b6c645db8424790eb4cf299d724f
78310ea]||{{{Merge branch 'u/vdelecroix/17730' into 6.6.rc0}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c75798cbe2b9e101f03c67d4ca9bc1c3624df31a
c75798c]||{{{trac #17730 review commit}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17730#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
