#17730: Use Pari for is_cyclotomic()
-------------------------------------+-------------------------------------
Reporter: bruno | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: number theory | Resolution:
Keywords: cyclotomic | Merged in:
polynomial | Reviewers:
Authors: Vincent Delecroix | Work issues:
Report Upstream: N/A | Commit:
Branch: | eabd6c8265bf8a30036e6a31595d7d700f4b1d5c
u/vdelecroix/17730 | Stopgaps:
Dependencies: #17631 |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* commit: c75798cbe2b9e101f03c67d4ca9bc1c3624df31a =>
eabd6c8265bf8a30036e6a31595d7d700f4b1d5c
* branch: public/ticket/17730 => u/vdelecroix/17730
Comment:
I do not like the fact that some argument forces the other silently. I do
prefer the version in which the combination
`p.is_cyclotomic(algorithm='sage', certificate=True)` raises an error. I
took care of some of your modifications in my commit.
On the other hand, there was a mistake in the previous version: the
arguments were not forwarded when the polynomial had coefficients in `QQ`.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=eabd6c8265bf8a30036e6a31595d7d700f4b1d5c
eabd6c8]||{{{Trac 17730: reviewer comments and more}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17730#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
