#17730: Use Pari for is_cyclotomic()
-------------------------------------+-------------------------------------
       Reporter:  bruno              |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  number theory      |   Resolution:
       Keywords:  cyclotomic         |    Merged in:
  polynomial                         |    Reviewers:
        Authors:  Vincent Delecroix  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  a70209cdf1fed0ece23327ef51a7e5456213ba1c
  public/ticket/17730                |     Stopgaps:
   Dependencies:  #17631             |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 Replying to [comment:13 chapoton]:
 > Well, I am doing that (where develop is the latest beta):
 > {{{
 > git ch develop -b 17XXX
 > git pull trac whatever_branch_for_17XXX
 > }}}
 > to get the branch.
 >
 > If the branch is not based on the latest beta, the merge is forced upon
 me by git.
 > This has been working for me very well since long, but maybe I am plain
 wrong in my use of git.

 My branch was based on beta-6.6 and the last beta is the rc0. This is the
 reason. The thing that I dislike is that it introduces a useless commit in
 the history. There is nothing bad with branch based on previous beta and
 instead you can do
 {{{
 git fetch trac whatever_branch_for_17XXX
 git ch -b 17XXX FETCH_HEAD
 }}}

 The alternative is to do the merge as you did. And then, you can rebase
 your commit on top of mine.

 Not that important.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/17730#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to