#18003: Implement Fully Packed Loop class
-------------------------------------+-------------------------------------
Reporter: kdilks | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: fpl, ncp, days64, | Merged in:
asm, lp, fully packed loop | Reviewers: Jessica Striker,
Authors: James Campbell, | Travis Scrimshaw
Vince Knight, Jessica Striker, | Work issues:
Kevin Dilks, Emily Gunawan | Commit:
Report Upstream: N/A | 0cbd4f6d2306e42b2e801c05ca81f2699df35a2d
Branch: | Stopgaps:
public/ticket/18003 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Okay, some comments after a quick look-over:
- I think you should implement a `toggle` map which swaps 2 vertical lines
and 2 horizontal lines.
- You should make a parent class for all fully packed loops (on an `n x n`
(m?) grid). The iterator could be a `TransitiveIdeal` generated by the
toggles (or some other type of search using toggles), but perhaps there is
a better way to do this. Also `FullyPackedLoop` then should be a subclass
of `Element`.
- The `.. math::` should be `.. MATH::`.
- You need more docuemntation for the class `FullyPackedLoop`, and the
first line should be something like `A fully packed loop.` (a sentence
which does not say "class", "implement", or other similar things). Also,
it would be good to have some more references.
- Perhaps the vertices could be `+` instead of `#`, or we set that as a
`global_option` (this is something I could do if you want)?
- Remove the commented out lines.
- The `fpl.plot().description()` output could potentially be machine
dependent, so it would be better to test the number of such elements.
I will possibly have more comments as I make a more detailed review.
However it's looking quite good.
This is more a note for myself to look at in more detail, but I think
contains some interesting followup ideas:
http://www.lpthe.jussieu.fr/~pzinn/semi/steklov.pdf.
--
Ticket URL: <http://trac.sagemath.org/ticket/18003#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
