#17282: Implementing Wehler K3 Surfaces
-------------------------------------+-------------------------------------
Reporter: jdefaria | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Ben Hutz, Grayson
Authors: Joao Alberto de | Jorgenson
Faria | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9b268f823c0e0ff35f0b881dadaa50ca72bfe875
u/jdefaria/ticket/17282 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* reviewer: => Ben Hutz, Grayson Jorgenson
Comment:
Started reviewing. Done through degenerate_fibers(). Will continue later.
From docbuild:
- top of file todo block not formatted correctly
- degenerate_fibers() - `` `` instead of ` `
- is_degenerate() - # lines
- is_isomorphic() - other -> right
- lambda_plus() - examples not formatted correctly
- sigmax() - P2 x 'P2 should not have '
- orbit_phi(), orbit_psi() - input not formatted correctly
From code:
- WehlerK3Surface: check that `polys` is a list or tuple
- randomWehlerK3:
- replace `getmon` with `xmrange([3,3])`
- Why can we choose L to be the diagonal bilinear polynomial
WehlerK3Surface_ring:
- init():
- get rid of ZZ(2),ZZ(2) - need to change ProductProjectiveSpace_init
- assert all(x.parent() is ZZ for x in N) to N=[Integer(x) for x in N]
- move TypeError check line 142 to line 135
- _morphism(): delete since it just inherits from parent
- change_ring() check not needed
- Sxa: condense the 4 lines
AS = self.ambient_space()
ASC = AS.coordinate_ring()
PSY = AS[1];
PSYC = PSY.coordinate_ring()
to
PSY = self.ambient_space()[1]
- Lx*, Qx*, Sx* - need to check that a is a point in P^2
- Ramification_poly():
- need to wrap return
- need to put in definition in documentation
- is_degenerate(): delete comments line 675-677
- degenerate_fibers():
- line 772-794: should use `rational_points` on subschemes from ticket
18008
- line 803-825: should use `rational_points` on subschemes from ticket
18008
- degenerate_primes(): document the algorithm
- rename: `badPrimes`
- todo - over number fields
--
Ticket URL: <http://trac.sagemath.org/ticket/17282#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
