#17282: Implementing Wehler K3 Surfaces
-------------------------------------+-------------------------------------
Reporter: jdefaria | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Ben Hutz, Grayson
Authors: Joao Alberto de | Jorgenson
Faria | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9b268f823c0e0ff35f0b881dadaa50ca72bfe875
u/jdefaria/ticket/17282 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by bhutz):
Review continues. All that is left after this block is the review the
sigmaX and sigmaY for degenerate fibers
is_smooth():
- Algorithm statement: is not a sentence
- remove extra spaces (line 940,941)
sigmaX:
- put doc string on new line (line 964). Better description in docstring
- [CaSi] does not enmpty lines around it
- Input: Point on surface in P^2 \times P^2
- make check like __call__ in projective morphism
- 1024: can just be else instead of elif
- remove extra spaces 987-988
- remove s= from degenerate examples
sigmaY:
- Better description in docstring
- [CaSi] does not enmpty lines around it
- Input: Point on surface in P^2 \times P^2
- make check like __call__ in projective morphism
- remove extra spaces 1170-1171
- remove s= from degenerate examples
- 1205: else instead of elif
phi:
- [CaSi] does not enmpty lines around it
- Input: Point on surface in P^2 \times P^2
- 1362: the point coordatines should be a list.
- remove extra spaces 1358-1359
- check can be false on the 2nd call
psi:
- white space around check = True
- [CaSi] does not enmpty lines around it
- Input: Point on surface in P^2 \times P^2
- 1362: the point coordatines should be a list.
- remove extra spaces 1394-1395
- check can be false on the 2nd call
lamba_plus:
- [CaSi] citation in description
- give a description of the algorithm
- ``P`` - a surface point
- remove extra spaces 1434-1435
- 1452-1453, 1455-1456 - less indendation
- rename localHeight - no CamelCase
- 1472-1477 use GPoly(1,l) do not need the ifs. Same for all of the 'if j
==' (1479 - 1496 -> one line)
- should the *Q[0][i]/Q[0][k] be PK not Q (as in 1508)
- reduce 1500-1524 to one line
- add some comments
- is 1529 using newQ so that the coordinates don't blow up??
lamba_minus:
- all the same comments
canonical_height_plus:
- [CaSi] citation in description
- give a description of the algorithm
- ``P`` - a surface point
- 1699: missing [] around coordinates
- 1708: one less indent
canonical_height_minus:
- all the same comments
canonical_height:
- better description
- give a description of the algorithm
- ``P`` - a surface point
- remove some extra spaces in examples
- 1817 - need [] around coordinate points
Fibers:
- The name of the function Fibers shouldn't be plural
- Fix the description
- input should be a P^2 (not a list) - so then also fix 1859-1863
- comment on why you have 'and' in the is_square
- citation (Hutz - Thesis)
- case 4.2.2 is missing in 1915-1918
- 1923 remove comment
- combine checking for duplicates with detereming the fiber (i.e., check
if in Fibers before adding
- rename Fibers to fiber
- 1940 remove this comment
orbit_phi:
- remove 1947
- input needs a blank line after and has a terminating white space that
should be removed
- fix description of N (see projective_point.orbit)
- another example where N is a list [m,n]
- can't always normalize such as in CC. Should you add a keyword as is
projective_point.orbit?
orbit_psi:
- all the same comments
is_isomorphic:
- add reasoning to the description
- add a False example
- fix example spacing
is_symmetric_orbit:
- blank line befor function
- better function description
- fixing spacing 2075-2076
- this could be given a list of random points. You need to also check the
each succesive is the image of the previous one
- actually you just be given a random list and the function would still
run...
FiberCounts:
- no camelcase for name
- make the name more descriptive of the output
- desribe algorithm (citation)
- actually this is just straight up enumeration
- add a TODO to use the more advanced counting (citation)
- 2134 - less indent
- 2137 needs another space around +
--
Ticket URL: <http://trac.sagemath.org/ticket/17282#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
