#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | d66d70dd8325ccb638289870c626652ac81d0fc7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:332 aschilling]:
> Replying to [comment:318 jdemeyer]:
> > The call to `_check_lexicographic_iterable` should be moved to
`IntegerListsLex.__iter__`
>
> Why?
Because it is really more logical that such a check would happen in the
parent before creating the iterator. The iterator should just iterate. The
check belongs to the code ''creating'' the iterator. Also, the
`check_finiteness` refers a lot to attributes of the parent, which means
that it really belongs there.
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:338>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.