#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | d66d70dd8325ccb638289870c626652ac81d0fc7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:334 git]:
> Branch pushed to git repo; I updated commit sha1. New commits:
>
||[http://git.sagemath.org/sage.git/commit/?id=58dced5c7b2eab36e50ba5df66d5cc562b14b2a8
58dced5]||{{{17979 address some review comments}}}||
You ''literally'' added just a check for `min_sum == Infinity`? That's
just completely inconsistent with the rest of the code. Please look at
`IntegerListsLex.__init__`. Really, do it. You will agree that it's an
ugly mess, see also [comment:317] (which just got worse).
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:340>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
