#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | d66d70dd8325ccb638289870c626652ac81d0fc7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:321 git]:
> Branch pushed to git repo; I updated commit sha1. New commits:
>
||[http://git.sagemath.org/sage.git/commit/?id=c9a047c28105498403b2ca2983a695ca9928beb8
c9a047c]||{{{trac #17979: Move imports to the (only) place in which they
are used}}}||
For the import of plain Python modules, I don't really see the
point. It's very unlikely that we will save on Sage startup time. On
the other hand, for e.g. `import collections`, we will pay a (small)
penalty each time an `IntegerListsLex` object is created.
>
||[http://git.sagemath.org/sage.git/commit/?id=c5f8c92e14e3a507f262799872902bf3d0b720df
c5f8c92]||{{{trac #17979: Replace |l| with sum(l) as it is only used
twice}}}||
Agreed for using `sum(l)` instead of `|l|` as notation.
On the other hand, I found useful to mention all the relevant
parameters on which we will put constraints in the introductory
paragraph, even if they are indeed trivial. Please revert if you agree
with that.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:342>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
