#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | 80ad5c8897ea2714a76a7a341b5652d622ae291a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello,
> In [comment:322] Jeroen agreed above that 319 was in fact ok.
Many times in the past I had to fix code which accepts a `**kwds`
and did not check that what it contains is actually read. This
lead to silent errors or wrong output, and so I immediately
things like `global_options` as the highway to bugs.
Jeroen noted that this variable is actually used somewhere else,
so I guess it probably should not be removed in this ticket. My
comment at [comment:319] still need to be adressed, however, as
there is no documentation for this parameter. Please make it
explain the uses of this flag, possibly by pointing to some other
part of the doc if it is already explained somewhere else.
> > The function `_possible_m(self, m, j, min_sum, max_sum)`
> > takes four parameters, all of which are attributes of `self`.
>
> I agree that this should eventually become an argument-less
> `look_ahead` method that tests if the current list could
> possibly be a prefix of some valid list. I would like to
> postpone this change to #18055 however
As the method appears in this branch, I see no reason to let it
be corrected in a future ticket.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:356>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
