#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
       Reporter:  aschilling         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  days64             |    Merged in:
        Authors:  Bryan Gillespie,   |    Reviewers:  Nathann Cohen, Jeroen
  Anne Schilling, Nicolas M. Thiery  |  Demeyer, Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/ticket/17979                |  3e3c7f6075e3b673911eb22faf427b0fb2a17b87
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by nthiery):

 Replying to [comment:356 ncohen]:
 > Many times in the past I had to fix code which accepts a `**kwds`
 > and did not check that what it contains is actually read. This
 > lead to silent errors or wrong output, and so I see
 > things like `global_options` as the highway to bugs.

 `**kwds` arguments can be painful, I certainly agree.

 But fear not, `__init__` takes no kwds. It only accepts a preexisting
 global_options object, and assigns it to the attribute
 `_global_options`, that's it.

 > Jeroen noted that this variable is actually used somewhere else,
 > so I guess it probably should not be removed in this ticket. My
 > comment at [comment:319] still need to be adressed, however, as
 > there is no documentation for this parameter. Please make it
 > explain the uses of this flag, possibly by pointing to some other
 > part of the doc if it is already explained somewhere else.

 I had not documented it to not advertise it, since we may well get rid
 of it. Now there is a documentation that spells exactly what it does.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=a0d2e639b0705327281759a89f6cda05a2288e25
 a0d2e63]||{{{17979: documentation for global_options}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=3e3c7f6075e3b673911eb22faf427b0fb2a17b87
 3e3c7f6]||{{{Simplify Envelope by using a sign}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:361>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to