#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | 7a35dc6ccf60379d060237e544287fda755861ce
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:390 jdemeyer]:
> In `_check_finiteness()`, I think you should move from a blacklist model
to a whitelist model: don't raise an exception if certain conditions are
satisfied, but raise an error ''unless'' the input can be seen to be
finite. This logic could not have the problem that adding conditions
breaks things.
Agreed. It's also easier to check step by step the correctness of each
good case. Done.
I am pretty sure I got the list of good cases right. But it's 1 am, so
please double check that I did not inadvertently remove a good case. At
least all tests in this file pass, and [comment:386] is now fixed.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=7a35dc6ccf60379d060237e544287fda755861ce
7a35dc6]||{{{17979: rewrite _check_finiteness using a whitelist of proven
good cases}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:393>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
