#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
       Reporter:  aschilling         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  days64             |    Merged in:
        Authors:  Bryan Gillespie,   |    Reviewers:  Nathann Cohen, Jeroen
  Anne Schilling, Nicolas M. Thiery  |  Demeyer, Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/ticket/17979                |  e151d78ea32b9cac2047e2faff3247bdcce1f5d5
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by nthiery):

 Replying to [comment:402 aschilling]:
 > Regarding Jeroen's comment:395, I think this could possibly be fixed by
 adjusting ._floor.limit_start() after the smoothing procedure.

 Agreed: we could imagine, in the constructor of Envelope and when a
 list is given as input, to set `limit_start` not to the end of the
 list, but to the point where the limit is actually reached after
 smoothing. It should be just a couple lines.

 Potential downside: if the parts in the list are very high, this may
 induce a similarly high limit start, which will trigger more
 calculations elsewhere. Probably not a common use case, so we might
 not care.

 The other thing is that I could well imagine that, once the new
 lookahead is implemented in #18055, the finiteness checking -- or at
 least the partial lookahead we are doing in `_check_finiteness` --
 would become a side product; so might not be worth having something
 temporary.

 So, reviewers: let us know if this should be done right now.

 Cheers,
                               Nicolas

--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:405>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to