#18025: SkewTableau.rectify() optimization
-------------------------------------+-------------------------------------
Reporter: MariaMonks | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64, tableau | Merged in:
Authors: Maria Monks | Reviewers: Josh Swanson
Gillespie, Oliver Pechenik | Work issues:
Report Upstream: N/A | Commit:
Branch: | ab4a84d739f7616a89a324c4723b7233cf5beb3c
u/jpswanson/skew_rectify | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by darij):
Was this a review, Josh?
I have two minor gripes (although I don't have a complete review, sorry):
1. The `la` and `la_size` definitions should be inside the `if algorithm
is None` branch. They aren't used otherwise.
2. Avoid the use of `Word`s when you don't need them (e.g., when lists are
sufficient). I am fairly sure (a quick experiment will suffice to tell)
that `Tableau([]).insert_word(self.to_word())` can be replaced by
`Tableau([]).insert_word(sum(row for row in reversed(self), []))` and will
speed up the method.
--
Ticket URL: <http://trac.sagemath.org/ticket/18025#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
