#16477: implement Dirichlet series
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: number theory | Resolution:
Keywords: moebius, zeta, | Merged in:
sigma, euler_phi, euler | Reviewers:
Authors: Jonathan Hanke, | Work issues: use pari, g.f. input
Ralf Stephan | Commit:
Report Upstream: N/A | 5698ef17c2be57ebe3826737cdba43f12c6bb8d6
Branch: u/rws/16477-1 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Hello,
1. there is no need to add method `dirmul` and `dirdiv` to the pari `gen`
object. This is taken care automatically since #17631. Doctesting is cool
thoug. But move it somewhere else.
2. Why is this new module in `sage.modular`? It makes no sense.
3. You should try harder to use `pari` and not `gp`. Since #17631, most
functions are available directly in `pari`.
4. `DirichletSeries` would better inherit from `RingElement`. In that
case, you must not define `__add__`, `__mul__`, `__div__` etc but `_add_`,
`_mul_`, `_div_`. That way you will get benefits from coercion (e.g.
multiplication by scalars). You might have a look to polynomials (in
`sage.rings.polynomials.*` or power series (in
`sage.rings.power_series_*`).
5. What is the purpose of the commented code?
6. The error must be new style ones. Please use
{{{
raise MyError("my message")
}}}
instead of
{{{
raise MyError, "my message"
}}}
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16477#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
