#18228: Developer guide: Do not change tickets with status "positive_review"
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: documentation | Resolution:
Keywords: | Merged in:
Authors: Clemens Heuberger | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/cheuberg/doc | Commit:
/do-not-change-positive-review- | e18c88688732d8d26ff3fc4a0723d14e8a37cf16
tickets | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello Clemens,
I totally agree with you on the fact that this is both tricky and
dangerous. On the other hand adding commits to positively reviewed tickets
is something that we do, and pretty often. Not only when we have forgotten
a typo/bug, but also in many cases when somebody sees a positively
reviewed ticket and *objects* with what is being done inside.
In this case that person will usually set the ticket back to `needs_work`
or `needs_info` to talk about the problem (s)he thinks the ticket
contains.
What I want to say is that having a rule like this would change radically
the way we do things in Sage. Thus, I am not saying that the problem
should not be addressed but rather that this is not a good way to solve
it.
From the point of view of the release manager, however, this is very easy
to detect: when he is about to merge a ticket, he can compare what he
merges with the current head of the branch. I it not very complicated to
implement, whatever script he uses.
This however, would still mean that he would run tests of a branch
*before* noticing that the branch has changed. What about this second way
out: when he starts the tests on a branch before merging it, he could
'freeze' the ticket (either by changing its status to 'closed: branch
testing' or even by only adding an (automatic) message on the ticket
saying "this branch is being tested, don't change its content".
Those two solutions (the second especially) are in my opinion much better
than changing the way we work, in particular because they don't add new
procedures and things to keep in mind when you contribute. The process is
less than straightforward and having an automatic message posted on a
ticket saying 'the release manager is running tests on its ticket before
inclusion' is both educative and a solution to the problem.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18228#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
