#18228: Developer guide: Do not change tickets with status "positive_review"
-------------------------------------+-------------------------------------
       Reporter:  cheuberg           |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  documentation      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Clemens Heuberger  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:  u/cheuberg/doc     |       Commit:
  /do-not-change-positive-review-    |  e18c88688732d8d26ff3fc4a0723d14e8a37cf16
  tickets                            |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hello,

 > > This however, would still mean that he would run tests of a branch
 *before* noticing that the branch has changed.
 >
 > As outlined by Volker in the sage-devel thread, this might lead to an
 infinite loop.

 `O_o`

 Are you answering to the procedure I explained above ? It can clearly be
 implemented with a 'if'.

 > If you convince the release manager to do that, I'll happily set modify
 this branch to include the proposed semantics.

 If you insist on changing the rules, please open a sage-devel thread
 explaining its consequences: no last-minute typo/bugfix, and no way to set
 to `needs_work` a ticket in `positive_review`. I am personally against it.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18228#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to