#18238: Options ignored in show() of 3D objects
-------------------------+-------------------------------------------------
Reporter: | Owner:
egourgoulhon | Status: needs_info
Type: | Milestone: sage-6.7
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Volker Braun
graphics | Work issues:
Keywords: | Commit:
Authors: Eric | ff3731d4078f7db2caf2b62cb8cc45b777753ef9
Gourgoulhon | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18238 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Replying to [comment:5 vbraun]:
> show shouldn't validate keyword arguments since it may have to fall back
to another viewer. E.g if you don't have java then it'll fall back to
tachyon and has to ignore jmol-specific arguments.
Then there is something wrong. The point of the method
`_process_viewing_options` is precisely to '''select''' the valid keywords
and modify some of their values. The remaining keywords are just ignored
(as Nathann already mentioned). And as far as I see,
`_process_viewing_options` is one method in `Graphics3d` which is
completely independent of the viewer. And it makes sense to have viewer
specific options.
And in `_save_image_png` (line 1367-1397), it seems to me that we have the
very same kind of problem
{{{
opts = self._process_viewing_options(kwds)
viewer = opts['viewer']
...
render = self._rich_repr_tachyon(OutputImagePng, **kwds)
...
scene = self._rich_repr_jmol(**kwds)
...
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/18238#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
