#18310: Finite dimensional modules with basis: improved conversions to vectors 
and
matrices
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nicolas M. ThiƩry  |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/categories/fin_dim_modules_with_basis_vector_matrix-18310|  
e3fd9394117180fd542e34eafa088bd95928488c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * commit:  3a433dc8318f07f85622c0f14116de51dac8bd20 =>
     e3fd9394117180fd542e34eafa088bd95928488c
 * branch:
u/nthiery/categories/finite_dimensinonal_modules_with_basis_vector_matrix-18310
     => public/categories/fin_dim_modules_with_basis_vector_matrix-18310
 * reviewer:   => Travis Scrimshaw


Comment:

 Looks good overall. This was something Darij and I wondered about when
 looking at Lie algebras (something I will need to change on that ticket).
 However I have a question about the `column` attribute in
 `FDModWithBasis.ParentMethods.matrix`. You currently have `assert not
 columns` in the method. Did you want that to be a `NotImplementedError`,
 or did you want to have that do something in this ticket?
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=b055669a1a57633bd827871b4bf20c3db7ce3d3e
 b055669]||{{{Merge branch
 
'u/nthiery/categories/finite_dimensinonal_modules_with_basis_vector_matrix-18310'
 of trac.sagemath.org:sage into
 public/categories/fin_dim_modules_with_basis_vector_matrix-18310}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=e3fd9394117180fd542e34eafa088bd95928488c
 e3fd939]||{{{Some trivial doc formatting cleanup from reviewer.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18310#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to