#18310: Finite dimensional modules with basis: improved conversions to vectors
and
matrices
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.7
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/categories/fin_dim_modules_with_basis_vector_matrix-18310|
642ab71f657054a9643b6f9de109f92d77cef421
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
Comment:
Replying to [comment:9 nthiery]:
> Replying to [comment:7 tscrim]:
> > Looks good overall; I made some minor doc formatting tweaks.
>
> I am happy with them; thanks! Isn't triple quoting of strings kind of
> overkill? Not that I really mind, but it's kind of heavy handed and
> really Sphinx should do that for us ...
It's 2 backticks and then a quote, so it gives it that nice code look in
the (non-interactive) doc (I prefer this because it is meant to reflect
exact user input).
> > However I have a question about the `column` attribute in
`FDModWithBasis.ParentMethods.matrix`. You currently have `assert not
columns` in the method. Did you want that to be a `NotImplementedError`,
or did you want to have that do something in this ticket?
>
> Oops; just a marker I had left for myself and I later forgot. There is
> a basic implementation now! Back to needs review.
Thanks. Positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/18310#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
