#18418: Clean Hyperbolicity Module
-------------------------------------+-------------------------------------
Reporter: borassi | Owner: borassi
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.7
Component: graph theory | Resolution:
Keywords: Hyperbolicity | Merged in:
Authors: borassi | Reviewers: David Coudert
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/borassi/clean_hyperbolicity_module|
4c55f5eeadc7539a443bdcec0797eff28e99da35
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dcoudert):
* status: needs_review => positive_review
* reviewer: => David Coudert
Old description:
> Improve the hyperbolicity module by performing the following cleanings:
>
> * rename "cuts" -> "CCL", "cuts+" -> "CCL+" or "CCL+FA";
> * set "CCL+" as default (it is faster);
> * include approximation algorithms using "cuts+" (already included, but
> an error is raised at the moment);
> * put counting sort of pairs in a separate routine;
> * use uint_32 and not uint_16 for pairs (graphs can have more than
> {2^16} vertices);
> * remove algorithm "basic+" (it is outperformed by many other
> algorithms).
New description:
Improve the hyperbolicity module by performing the following cleanings:
* rename "cuts" -> "CCL", "cuts+" -> "CCL+" or "CCL+FA";
* set "CCL+" as default (it is faster);
* include approximation algorithms using "cuts+" (already included, but
an error is raised at the moment);
* put counting sort of pairs in a separate routine;
* use uint_32 and not uint_16 for pairs (graphs can have more than `2^16`
vertices);
* rename algorithm "basic+" to "basic".
--
Comment:
You are perfectly right!
For me this patch is now good to go.
David.
--
Ticket URL: <http://trac.sagemath.org/ticket/18418#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
