#18418: Clean Hyperbolicity Module
-------------------------------------+-------------------------------------
Reporter: borassi | Owner: borassi
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: graph theory | Resolution:
Keywords: Hyperbolicity | Merged in:
Authors: borassi | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/borassi/clean_hyperbolicity_module|
8a7ffe1d55e5efee710c4a50a6ae406674737e68
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by borassi):
Hello!
> - editing remark : comments must be formatted in 80 columns format.
Don't ask why ;)
Done
> - in the sort_pairs method, you are not using quick sort but counting
sort
Yeah, sorry, wrong comment. Corrected.
> - there is a recent and useful method for malloc. See file
`generic_graph_pyx.pyx` for example
> {{{
> from sage.ext.memory cimport check_allocarray, sage_malloc, sage_free
> elist = <int*>check_allocarray(2 * len(G.edges()) + 2, sizeof(int))
> }}}
Done
> - I agree to remove `basic+`, although I would have prefer to rename
`basic+` into `basic` and remove the old `basic` which is slower. The
basic method is useful only for comparison purpose.
I replaced the code of `basic` with the old cose of `basic+`.
> - the purpose of the `triples` list is to avoid computing many times the
sum S1. It adds a loop but reduces the number of operations. Do you have a
better solution in mind ?
I see your point: very nice solution! My solution was simply to recompute
`S1` every time.
--
Ticket URL: <http://trac.sagemath.org/ticket/18418#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
