#18418: Clean Hyperbolicity Module
-------------------------------------+-------------------------------------
Reporter: borassi | Owner: borassi
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: graph theory | Resolution:
Keywords: Hyperbolicity | Merged in:
Authors: borassi | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/borassi/clean_hyperbolicity_module|
8a7ffe1d55e5efee710c4a50a6ae406674737e68
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dcoudert):
Hello,
Be careful with global name replacements
{{{
- performs very well in practice since it cuts the search space.
This
+ performs very well in practice since it CCL the search space. This
}}}
In method `sort_pairs`, you should
- Add a first comment line like `Return a list of pairs sorted in
decreasing order of values`. Almost all methods have such a one line
description.
- declare the types of local variables i,j,k
In method `__hyperbolicity__`, you should
- Replace `cdef uint32_t *nb_p = <uint32_t>check...` with `cdef uint32_t
nb_p` and then call `sort_pairs` with `&nb_p` and use `nb_p` rather than
`nb_p[0]`
You could also rename some methods
- `__hyperbolicity_basic_algorithm__` -> `hyperbolicity_basic_algorithm`
- `__hyperbolicity__` -> `hyperbolicity_CCL`
These methods are cdef, they are not visible at Python level.
--
Ticket URL: <http://trac.sagemath.org/ticket/18418#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
