#18357: Unicode Art
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.8
Component: user interface | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/18357 | 161c0daca2f4a4752725225dfb9238ffc9692ddf
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
* commit: 980c2f60198abcc9a2ea6b415d3849c2b24c12b2 =>
161c0daca2f4a4752725225dfb9238ffc9692ddf
* milestone: sage-6.7 => sage-6.8
* branch: u/vbraun/unicode_art => u/vdelecroix/18357
* reviewer: => Vincent Delecroix
Comment:
Hello,
Two commits to:
- get rid of trailing whitespaces
- clean up a bit `CharacterArt/CharacterArtFactory`. I would like to do
more cleanup but need your opinions on several points.
1. Why does `CharacterArt` inherits from `SageObject`? And
`CharacterArtFactory`? Do you mind if I get rid of this?
2. In `build_comma_sequence`, there is a very original
{{{
"" ** ZZ(repr_elems._h - 1 - repr_elems._baseline)
}}}
Is there any mysterious reason?
3. Wouldn't be better to make the `CharacterArtFactory` callable and make
it replace the two functions `unicode_art` and `ascii_art`?
4. It would be cool to make tableaux part of the `CharacterArtFactory`
(certainly for another ticket).
5. Could we get rid of `CompoundSymbol.print_to_stdout`? This could be
tested inside `__call__`.
6. You defined symbols for the integral but these are not used...
7. In my console the curly braces of height 2 does not print correctly, ie
those two
{{{
unicodedata.lookup('UPPER LEFT OR LOWER RIGHT CURLY BRACKET SECTION')
unicodedata.lookup('UPPER RIGHT OR LOWER LEFT CURLY BRACKET SECTION')
}}}
Are these two standard?
Vincent
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=03a98546bb4945bb5a5da59c1d1f39d6bdb9839b
03a9854]||{{{Trac 18357: remove trailing whitespaces}}}||
||[http://git.sagemath.org/sage.git/commit/?id=161c0daca2f4a4752725225dfb9238ffc9692ddf
161c0da]||{{{Trac 18357: cleanup in character art}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18357#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
