#18527: Hughes Plane for block_design
-------------------------------------+-------------------------------------
Reporter: q.honore | Owner:
Type: PLEASE CHANGE | Status: new
Priority: major | Milestone: sage-6.8
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: q.honore | Work issues:
Report Upstream: N/A | Commit:
Branch: | 41ed54d014a84a5aaf1925a99819e49ac4451af6
u/q.honore/hughes_plane | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Some more comments:
1. you should break the lines in your comments. The line {{{The
construction of a Hughes plane is based on a nearfield ...}}} is one
kilometer long. Try to keep the width around 80.
2. you should align the comments `# xyz` with the code
3. It would be cool to have some code in the `EXAMPLES` section which
proves that Hughes plane are indeed different from the standard finite
projective plane. You can show that the theorem of Desargues is not
satisfied.
4. For the function `normalize` it would be better to say that it is only
intended to be used in `HughesPlane`. And you can even call it
`normalize_hughes_plane_point`, in other words choose something more
explicit.
5. In the function `HughesPlane`, it would be nice to add few words
explaining the construction and also add references (for example to Hughes
original article and also Dembowski 1971)
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18527#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
