#18527: Hughes Plane for block_design
-------------------------------------+-------------------------------------
       Reporter:  q.honore           |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.8
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:  Vincent Delecroix
        Authors:  Quentin Honoré     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/18527       |  47c7c21ee183abe487b7376a7bc38834f7b2177c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * status:  needs_review => needs_work
 * commit:  2182aaad7de85fc5d35aecac64996fc14f95539a =>
     47c7c21ee183abe487b7376a7bc38834f7b2177c
 * branch:  u/q.honore/hughes_plane => public/18527
 * reviewer:   => Vincent Delecroix


Comment:

 Hello Quentin,

 There is a lot of work to do in the documentation. Most of it is
 uncomprehensible. Hopefully I know what you are trying to do but any other
 person will not get a word. I already modified some of it in my commit at
 `public/18527` but there are still a lot of things to do:
  - In `HughesPlane` the following sentence is uncomprehensible
 {{{
     For p an odd prime.
     If kernel K of order `p^n` coincides with the center of a nearfield N.
     The construction of a Hughes plane is based on N of order `p^2n`.
 }}}
    you should explain '''simply''' what is the Hughes plane. If it is
 complicated just make a reference to wikipedia and just explain what it is
 (e.g. The Hughes plane is a finite projective plane introduced by XYZ and
 which is not Desarguesian)

 - If you want to include mathematics formula in the documentation you must
 use the block `MATH`. This is described in details in
 [http://doc.sagemath.org/html/en/developer/coding_basics.html
 #documentation-strings the developer's guide]

 - the example that shows that the Hughes plane is not Desarguesian is not
 finished... And you should explain what you are doing with sentences (not
 Python comments starting with `#`). I already modified and simplified the
 begining.

 Vincent
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=47c7c21ee183abe487b7376a7bc38834f7b2177c
 47c7c21]||{{{Trac #18527 (review): improve the documentation}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18527#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to