#18527: Hughes Plane for block_design
-------------------------------------+-------------------------------------
Reporter: q.honore | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Quentin Honoré | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18527 | 799f921acccacc4e48dcd11b46caab9b2d0d4ea7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Hello,
When you are done with your changes, you need to set back to `needs
review`. That way I know that I need to have a look.
Some more comments:
- with your last commit the test do not pass
- put spaces around equality signs `a = b` and not `a=b`. Similarly, add
spaces in function declaration `f(a, b)` and not `f(a,b)`.
- When you define the Hughes plane you start with `p` being an odd prime
but it is never used
- for coherence of notations, instead of using `n2` and `n` it would be
better to use `q2` and `q` (and do not forget to modify the `INPUT`
section)
I did a bit of profiling and it appears that most of the time is spent in
doing matrix by vector multiplication! I will try to see whether it is
possible to improve that part (in another ticket).
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18527#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
