#18527: Hughes Plane for block_design
-------------------------------------+-------------------------------------
Reporter: q.honore | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Quentin Honoré | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18527 | 7e2070f578c112043ed8cf9d367a5ab4e20cbdff
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
In my review commits I changed few things (removed `random` from
`random_q3_minus_one_matrix`, make `HughesPlane` works for non prime `q`
and improve a bit the code).
There are still some issues with the documentation. Please pay more
attention to what you write.
You wrote
{{{
Return the Hughes projective plane of order `n2`.
}}}
But the name of the parameter is now `q2`. Moreover you must use double
quotes for the parameters {{{``q2```}}}. Simple ones are for latex code.
This is not a sentence
{{{
For q an odd prime.
}}}
When you test the fact that it is not Desarguesian, it is weird to do it
in two ways. Here you print the name of the points
{{{
sage: set(b_0_1).intersection(b_57_70)
{2}
sage: set(b_1_10).intersection(b_70_59)
{73}
sage: set(b_10_0).intersection(b_59_57)
{60}
}}}
But then you just test equality
{{{
sage: p = set(b_0_57).intersection(b_1_70)
sage: q = set(b_1_70).intersection(b_10_59)
sage: p == q
False
}}}
You should do it coherently.
You can also add a section `AUTHORS` with your name in the function
`HughesPlane` (see the developer guide).
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18527#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
