#18558: Test all installed optional packages by default
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  doctest framework  |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nathann Cohen,     |    Reviewers:  Jeroen Demeyer, Karl-
  Jeroen Demeyer                     |  Dieter Crisman
Report Upstream:  N/A                |  Work issues:
         Branch:  u/jdemeyer/18558   |       Commit:
   Dependencies:  #18456, #18124,    |  e3f463d32d4d05a55f8cee4315bb01d9c5de2da2
  #18559, #18563, #18579, #18581     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 Replying to [comment:119 kcrisman]:
 > I think we should find a way to remove optional tags that aren't
 actually optional (`scons`? `python2`?).  It's just confusing.
 On the other hand, it allows tests only on `python2` or `python3`, that
 might be actually useful. And `scons` was made optional just because the
 Python 3 porting people asked for that. I would just live with this, it's
 not really a problem anyway. It's only shown in the beginning of the
 doctest log.

 > The following doesn't provide me any way to tell that the problem was
 with a `gambit` optional test (it's not broken, I just broke it to test
 this.
 > {{{
 > sage -t src/sage/game_theory/gambit_docs.py
 > **********************************************************************
 > File "src/sage/game_theory/gambit_docs.py", line 124, in
 sage.game_theory.gambit_docs
 > Failed example:
 >     g[int(2), int(0)][int(0)] = int(0)  # optional - gambit
 > Exception raised:
 > <snip>
 >     IndexError: Provided strategy index 2 out of range for player 0
 > **********************************************************************
 > 1 item had failures:
 >    1 of  13 in sage.game_theory.gambit_docs
 >     [12 tests, 1 failure, 0.14 s]
 > ----------------------------------------------------------------------
 > sage -t src/sage/game_theory/gambit_docs.py  # 1 doctest failed
 > ----------------------------------------------------------------------
 > }}}
 > I'm saying that this works, apparently, but doesn't give any indication
 that it failed due to an ''optional'' test.  'Needs work' or at least
 'needs info'.
 The "Failed example" shows `# optional - gambit`. Is that not clear
 enough?

--
Ticket URL: <http://trac.sagemath.org/ticket/18558#comment:124>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to