#18514: Upgrade of group cohomology spkg
-------------------------------------------------+-------------------------
       Reporter:  SimonKing                      |        Owner:
           Type:  defect                         |       Status:
       Priority:  major                          |  needs_review
      Component:  packages: optional             |    Milestone:  sage-6.8
       Keywords:  group cohomology               |   Resolution:
        Authors:  Simon King                     |    Merged in:
Report Upstream:  None of the above - read trac  |    Reviewers:
  for reasoning.                                 |  Work issues:
         Branch:                                 |       Commit:
   Dependencies:                                 |     Stopgaps:
-------------------------------------------------+-------------------------

Comment (by jdemeyer):

 In `setup.py`, replace
 {{{
 #!python
               include_dirs = CSAGE_PATH + [
                               os.path.join(SAGE_SRC,"c_lib","include"),
                               SAGE_EXTCODE, SRC_EXT,
                               os.path.join("mtx2.2.4","src"),
 os.path.join("pGroupCohomology","c_sources"),
                               "pGroupCohomology"]
 }}}
 by
 {{{
 #!python
 try:
     # Sage >= 6.8
     from sage.env import sage_include_directories
 except ImportError:
     # Sage < 6.8
     def sage_include_directories():
         return [
             os.path.join(SAGE_LOCAL, "include", "csage"),
             os.path.join(SAGE_SRC, "c_lib", "include"),
             SAGE_EXTCODE, SRC_EXT]  # Not sure that you really need
 SAGE_EXTCODE

 ...

               include_dirs = sage_include_directories() + [
                              os.path.join("mtx2.2.4","src"),
                              os.path.join("pGroupCohomology","c_sources"),
                              "pGroupCohomology"]
 }}}
 and use #18494.

--
Ticket URL: <http://trac.sagemath.org/ticket/18514#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to