#18710: Move some make targets to build/Makefile
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: build | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/move_some_make_targets_to_build_makefile|
5b6ec50788f2cd19f575adf5f2725d77c4ba6cc3
Dependencies: #18533, #18715, | Stopgaps:
#18716 |
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:35 ncohen]:
> Right. Do we agree that before your branch is applied, this "number 2
logging" in `install.log` is only performed for 'make build'?
Ye. However, let me remark that most top-level targets depend on `build`,
so the "build" part of those targets is also logged in `install.log`.
> With the new fallback `%::` rule that you added, all calls to 'make X'
that are not defined in `SAGE_ROOT/Makefile` are forwarded to
`build/Makefile`. Thus, after your branch is applied, the output of `make
doc-html` is logged in `install.log`.
True. But this is a feature, not a bug.
> (assuming that we agree on that) Before your branch is applied, the
output of `make doc-html` was not logged in `install.log`.
Obviously true.
> (assuming that we agree on that) Why wouldn't we remove the logging from
the `%::` rule, and only add it in the `make build` rule (which is now the
`make all-build` rule from `build/Makefile`)?
See the last paragraph of [comment:34]. Those reasons make sense for `make
doc` as much for `make build`.
--
Ticket URL: <http://trac.sagemath.org/ticket/18710#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
