#18710: Move some make targets to build/Makefile
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: build | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/move_some_make_targets_to_build_makefile|
5b6ec50788f2cd19f575adf5f2725d77c4ba6cc3
Dependencies: #18533, #18715, | Stopgaps:
#18716 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Okay. From what you say, it appears to me that:
1) After your branch is applied, "make build" is logged exactly as
previously in `install.log`
2) After your branch is applied, the output of `make doc-html` is logged
in `install.log`. As it triggers a `make build`, then the output of `make
build` is logged twice in `install.log` (once in `make doc-html`, once in
the triggered `make build`)
3) My problem with your `%::` is that is that it covers *any* kind of
rule, even those that we will add in the future. Promising right now that
any rules that is aliased from `Makefile` to `build/Makefile` will be
logged in `install.log` looks too wide for me.
Thus, could you remove this logging from the `%::` rule? You could add the
same logging in the `make all-sage` rule. It would also let you add a more
specific logging of `make doc` that would not cover the subsequent call to
`make build`, thus we would not double-log that.
> See the last paragraph of [comment:34]. Those reasons make sense for
`make doc` as much for `make build`.
I would have less problem if you were only adding those rules in `make
doc` and `make build`. Right now you are doing this in a wider scope: you
apply then to all rules that are aliased, even those that will be added
later.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18710#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
