#18539: faster matroid 3 connectivity
-------------------------------------+-------------------------------------
Reporter: chaoxu | Owner: chaoxu
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: matroid theory | Resolution:
Keywords: | Merged in:
Authors: Chao Xu | Reviewers: Michael Welsh
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/chaoxu/faster_matroid_3_connectivity|
6a3484d37844b63bc30da968e58bc2ccf8836486
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by Rudi):
Hi Chao,
I think the code as such looks great and works great. Repair these last
few issues and I'll give a positive review:
The docstring of is_3connected only mentions BC under `..ALGORITHM:`.
Please also describe the other method.
When _is_3connected_BC throws `NotImplementedError,` give a description
of the problem , e.g. NotImplementedError("The Bixby-Cunningham algorithm
does not return a separation")
In the docstring of _is_3connected_CE and _is_3connected_BC, there are
several X and one T that need to have single accolades (now double). You
can check the appearance of the docstring in the notebook by entering
`M._is_3connected_BC?` on a matroid M.
Finally, I don't believe keeping&depricating the option `separation` is
necessary in this case. This option was introduced in 6.8 beta and so
never saw an official release. So if we make sure it's gone before 6.8 is
released we should be fine.
If the others agree you can perhaps still change this. Otherwise I'll give
the positive review after you settled the above 3 issues.
--
Ticket URL: <http://trac.sagemath.org/ticket/18539#comment:42>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
